search

bcuff / elasticsearch-net-aws

Add-on to Elasticsearch.Net & NEST for using AWS's elasticsearch service.
Apache License 2.0
72 stars 27 forks source link

Support for .NETFramework 4.5 and .NETStandard 1.3 #16

Closed nanestev closed 7 years ago

nanestev commented 7 years ago

Support for net45 comes at the price of a couple compiler directives because ElasticSearch.Net for net45 has different API. Also I needed to create abstraction of request and header collection to be able to reuse the original code with both HttpRequestMessage/WebHeaderCollection and HttpWebRequest/HttpRequestHeaders and all the differences that come with them. Very few other changes of the original code like ditching JavaScriptSerializer in favor of JSON.Net. Unit tests run for both netcore and net451 (because NUnit runner is targetting net451). The signing key was not present so had to switch off signing, but you can always switch it back on. Also I added Token property to the AwsSettings class. It is needed, because we can't use role credentials without it (for example when working with assumed roles or ECS task roles).

Cheers! N

davemcdermid commented 7 years ago

Hey, what's the status of this pull-req? Been testing locally, would love to have access to a pre-release on nuget.org :)

Thanks

bcuff commented 7 years ago

@davemcdermid Looks good. I just need to test it on my end before I push a release. I'll try to get that done soon.

bcuff commented 7 years ago

@davemcdermid @nanestev nuget released as 2.2.0

davemcdermid commented 7 years ago

Fantastic, thank you!

bcuff commented 7 years ago

you're welcome