is there any way to avoid the large dependency update in 2.3.x?

bcuff / elasticsearch-net-aws

Add-on to Elasticsearch.Net & NEST for using AWS's elasticsearch service.

Apache License 2.0

72 stars 27 forks source link

is there any way to avoid the large dependency update in 2.3.x? #22

Closed jaz-ah closed 7 years ago

jaz-ah commented 7 years ago

I currently have a project that is based on .Net Framework 4.6.2 - when trying to upgrade this nuget from 2.1.4->2.3.3, I get a large list of dependencies which i believe are required for a project depending on .Net Standard but not for .Net Framework - is there any way to avoid injesting this large dependency list in my case? or do I update the nuget and then manually remove the dependencies that aren't required?

jaz-ah commented 7 years ago

otherwise @bcuff my diff on this nuget update looks like:

bcuff commented 7 years ago

Hmm... the NETStandard.Library packages shouldn't come in unless you're on a dotnetcore / dotnetstandard build. The version of nuget you're using to update the package may be confused about which dependencies it ought to take.

You could

Update nuget and retry.
Manually install the package and add the reference to your project.

jaz-ah commented 7 years ago

I'm on VS2017, using the nuget3 api for fetching... I can manually install the package and see if that works, I just worry that i'll have to do this anytime any updates happen - haven't seen this in other nugets yet...

bcuff commented 7 years ago

Okay, thanks for the info. I'll play with it and see if I can fix the package so it doesn't do that.

jaz-ah commented 7 years ago

thx @bcuff let me know if you want me to test anything out for you.

bcuff commented 7 years ago

@jaz-ah I just uploaded a new release that should fix the problem

https://www.nuget.org/packages/Elasticsearch.Net.Aws/2.3.4

jaz-ah commented 7 years ago

yup works thx @bcuff !