search

bcuff / elasticsearch-net-aws

Add-on to Elasticsearch.Net & NEST for using AWS's elasticsearch service.
Apache License 2.0
72 stars 27 forks source link

Doesn't seem to be compatible with v6.0.0 (ElasticSearch.Net 6.0.0-rc1) #33

Closed pjninnis closed 6 years ago

pjninnis commented 6 years ago

It looks like the internals of the 6.0 release has changed slightly. I'm getting this exception:

System.MissingMethodException Method not found: 'Elasticsearch.Net.PostData1<System.Object> Elasticsearch.Net.RequestData.get_PostData()'. at Elasticsearch.Net.Aws.AwsHttpConnection.SignRequest(IRequest request, RequestData requestData) at Elasticsearch.Net.Aws.AwsHttpConnection.CreateHttpWebRequest(RequestData requestData) at Elasticsearch.Net.HttpConnection.Request[TResponse](RequestData requestData) in c:\Source\elasticsearch-net-master\src\Elasticsearch.Net\Connection\HttpConnection.cs:line 147 at Elasticsearch.Net.RequestPipeline.CallElasticsearch[TResponse](RequestData requestData) in c:\Source\elasticsearch-net-master\src\Elasticsearch.Net\Transport\Pipeline\RequestPipeline.cs:line 439 at Elasticsearch.Net.Transport1.Request[TResponse](HttpMethod method, String path, PostData data, IRequestParameters requestParameters) in c:\Source\elasticsearch-net-master\src\Elasticsearch.Net\Transport\Transport.cs:line 68

pjninnis commented 6 years ago

Can anyone confirm if this library should currently work with version 6.0.0+ and if so, post some sample code?

bcuff commented 6 years ago

Thanks for the report. I've had to refactor after every ES major version so I suspect it is broken. I'll get around to fixing it eventually. I also accept PR's :)

pjninnis commented 6 years ago

Thanks, now that AWS allows us to put the ES cluster within a VPC, it no longer needs to be signed, so it's less important now anyway.

thoean commented 6 years ago

See #34 where I worked a bit towards making this library work with v6. I won't need the features in this library, so I won't pursue the PR further. However, I thought it's valuable sharing my initial findings.

justintoth commented 6 years ago

Any update on getting this package working with ES 6? I've been using the 5.x nuget packages to avoid this error, however now I'm trying to write a match query and am running into this issue, which seems to only be fixed by upgrading to 6. So I'm blocked, basically...

bcuff commented 6 years ago

Just pushed an update. ES 6 should now work. Please reopen if that isn't the case. https://www.nuget.org/packages/Elasticsearch.Net.Aws/6.0.0

justintoth commented 6 years ago

Works great, thanks.

bcuff commented 6 years ago

you're welcome