search

bcuff / elasticsearch-net-aws

Add-on to Elasticsearch.Net & NEST for using AWS's elasticsearch service.
Apache License 2.0
72 stars 27 forks source link

AWS Dependencies Issue #61

Closed phillip-haydon closed 3 years ago

phillip-haydon commented 3 years ago

Hey, there seems to be a disconnect between the nuget package and whats in the repository.

https://www.nuget.org/packages/Elasticsearch.Net.Aws/

This states:

AWSSDK.Extensions.NETCore.Setup (>= 3.3.100.1)

Which is causing problems as AWS just released 3.5 of their libraries.

https://www.nuget.org/packages/AWSSDK.Extensions.NETCore.Setup/

This is on 3.3.101 which supports AWSSDK.Core as AWSSDK.Core (>= 3.3.13.3 && < 3.6.0)

But the nuspec doesn't even specify this dependency at all. So I'm a bit confused.

This is causing build warnings at the moment:

Screenshot_20200821_122609

Do you want a PR to fix this up?

bcuff commented 3 years ago

No but thanks for reporting the issue. I was able to resolve the issue by simply re-building.

The build just references <PackageReference Include="AWSSDK.Extensions.NETCore.Setup" Version="3.3.*" /> and the last time I built the package it was on 3.3.100.1 which wants AWSSDK.Core < 3.4.0

If you don't explicitly reference a higher version of AWSSDK.Extensions.NETCore.Setup in your own project then it will resolve the lowest version required by your dependencies which had that AWSSDK < 3.4 constraint.

TLDR - Updating your ref to 7.0.5 should resolve your issue.

Feel free to reopen if that turns out not to be the case.

phillip-haydon commented 3 years ago

Thanks for the quick fix @bcuff, the build errors are gone. Appreciate you pushing the nuget so quickly!