bcurran3 / ChocolateyPackages

My published Chocolatey packages
206 stars 94 forks source link

Upgrade SetACL from 3.0.6 to 3.1.2 fixing #309 #310

Closed jpluimers closed 1 year ago

jpluimers commented 1 year ago

Updates .nuspec (version) and install script (download URL and sha256)

fixes #309

aetonsi commented 1 year ago

Hi @bcurran3, any timeline about the possible merging of this? And thanks @jpluimers, hope you're doing well

bcurran3 commented 1 year ago

Repo is finally sync fixed!

Not sure why choco-cleaner files are mixed in with this... possibly from "fixing" the repo?

If this is still current and you pull out the CC stuff, I'll probably pull it in this weekend. Sorry for the delay.

aetonsi commented 1 year ago

If this is still current

v3.1.2 is still the latest version if that's what you're asking

bcurran3 commented 1 year ago

Can you pull the choco-cleaner stuff from the PR please? I tried, not sure I did it right.

bcurran3 commented 1 year ago

Ironically I updated the package back in Oct 2022 but never pushed it.

nuspec needed more updating to fix markdown issues, add release notes and other things. install script needed more updating as there are 32bit and 64bit versions of the program and shimgen would make a shim for each; first overwriting the 2nd. So if you're on a 32bit machine the shim wouldn't work since it was pointing to the 64bit version. I now autogenerate an .ignore file for the non-appropriate file during install.

Pushed new version. choco install setacl --version=3.1.2.86

aetonsi commented 1 year ago

Hi, just out of curiosity, how long does it take for chocolatey to make a new version (3.1.2 in this case) the "main" one? Or will it always be necessary to specify --version=xxx to upgrade?

bcurran3 commented 1 year ago

Until a package has been updated at least 3 times with no problems, it has to go through human moderation. That moderation can take a few days to a month depending on how big the queue is and the time availability of the volunteers that do it.

aetonsi commented 1 year ago

Oh ok i see, thanks for the info. Cool to know.

jpluimers commented 7 months ago

Hi @bcurran3, any timeline about the possible merging of this? And thanks @jpluimers, hope you're doing well

Thanks. I'm still alive and doing OK. Will post an update to the original issue shortly.