chocolatey-fastanswers.extension - Get-IsWin8 needs minor version qualifier

bcurran3 / ChocolateyPackages

My published Chocolatey packages

206 stars 94 forks source link

chocolatey-fastanswers.extension - Get-IsWin8 needs minor version qualifier #331

Closed brogers5 closed 7 months ago

brogers5 commented 1 year ago

Get-IsWin8's implementation only checks against the Windows NT kernel's major version (6), which is also shared with Windows Vista and 7. This causes a false positive:

False Positive screenshot

The minor version should be 2 for Windows 8, and 3 for Windows 8.1.

bcurran3 commented 1 year ago

Thanks. It's nice to see someone actually using this!

bcurran3 commented 7 months ago

Closing this as I am no longer creating or maintaining Chocolatey packages. Sorry, out of my control.

Hopefully you've enjoyed my work and found it useful.