Feature add margin spacing support

bcvery1 / tilepix

Library for combining tiled maps with pixel

MIT License

46 stars 14 forks source link

Feature add margin spacing support #82

Closed perber closed 5 years ago

perber commented 5 years ago

Checklist Ensure all of these are completed before opening the PR:

[X] Run goimports
[X] Read the contribution guide
[X] Read the code of conduct
[X] Read the coding standards
[X] Tests run with -race
[x] Tests written to cover any new code
[X] Added yourself to the contributors file

Describe the changes Added support for margin and spacing

Closing issues Resolves #59

bcvery1 commented 5 years ago

It looks like this is failing for older versions of Go. This may just be a Travis issue

bcvery1 commented 5 years ago

@perber I'm happy to merge this once tests are passing. I'll take a look at the reason behind the failure when I can, but if you think you can figure it out, please go ahead

perber commented 5 years ago

@bcvery1 I will take a look at the travis issue.

perber commented 5 years ago

Hi, https://github.com/golang/go/issues/31293

There are two possible solutions. Stick to previous go version, than the builds will be successuful or update to a new ubuntu distro. I would prefer to update to a new distribution.

Edit: I`ve changed the travis.yml file to use the newer xenial distro

bcvery1 commented 5 years ago

Yeah, I agree that the change in distro is the best choice here. Thanks for taking the time to look further into this issue than was the scope of the original issue!

I'll merge this now