Add support for reading maps that use external (unembedded) tilesets

bcvery1 / tilepix

Library for combining tiled maps with pixel

MIT License

46 stars 14 forks source link

Add support for reading maps that use external (unembedded) tilesets #87

Closed tjbrockmeyer closed 5 years ago

tjbrockmeyer commented 5 years ago

Checklist Ensure all of these are completed before opening the PR:

[X] Run goimports
[X] Read the contribution guide
[X] Read the code of conduct
[X] Read the coding standards
[X] Tests run with -race
[X] Tests written to cover any new code
[X] Added yourself to the contributors file

Describe the changes Added two functions for reading tilesets from .tsx xml format. One for reading a file, the other for reading from a reader. Added an additional section during the Read()ing of Maps to update the read tilesets with their source content, if applicable.

Closing issues Resolves #86

bcvery1 commented 5 years ago

Thanks for your patience waiting on this PR. I've been away on holiday, but now I'm back I'll look into getting this merged ASAP

bcvery1 commented 5 years ago

@tjbrockmeyer I'm keen to get this merged, I think it's a really helpful addition; how do you feel about the suggested changes?

tjbrockmeyer commented 5 years ago

My bad, I've been a bit busy with other stuff and I never got around to finishing this up. The changes look fine to me. I'll get it done asap 👍

tjbrockmeyer commented 5 years ago

There is code in tilepix.go: m := new(Map) if err := d.Decode(m); err != nil {

This is what I modeled my changes on, and I would suggest changing it to be consistent with the changes that you have requested here, or reverting the changes that I just made in order to remain consistent with what I modeled them after.

Other than that, the changes are ready to go.

bcvery1 commented 5 years ago

Thanks for spotting that, I will have to patch that.

Thanks for this PR!