fges penalty discount not working

bd2kccd / causal-cmd

16 stars 8 forks source link

fges penalty discount not working #48

Closed rubenSaro closed 4 years ago

rubenSaro commented 4 years ago

@kvb2univpitt Hi,

I checked the new release (1.1.2) and you do not get the error regarding the penaltyDiscount, but the algorithm seems to be not using that info., and probably running at its default value.

I tried different penaltyDiscount values, and always got the same graph.

Also, in the txt output you cannot see which value of penaltyDiscount you entered, it is not listed in the parameters list.

Ruben

kvb2univpitt commented 4 years ago

@rubenSaro Thanks. I'll take a look at it and get back to you.

kvb2univpitt commented 4 years ago

@rubenSaro OK. It's now fixed. I tested it. The penaltyDiscount parameter now work. Thanks.

jdramsey commented 4 years ago

Yayyyyyy! -Joe

rubenSaro commented 4 years ago

Thanks a lot Kevin !!!

El vie., 1 nov. 2019 a las 16:47, Joseph Ramsey (notifications@github.com) escribió:

Yayyyyyy! -Joe

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bd2kccd/causal-cmd/issues/48?email_source=notifications&email_token=AJUZSFMRWRL2SW56W6BFAE3QRSIUXA5CNFSM4JHP64O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4DYIY#issuecomment-548944931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJUZSFP3WBJTQKKVMF532OLQRSIUXANCNFSM4JHP64OQ .