search

bd2kccd / py-causal

Other
204 stars 50 forks source link

Results changed in v1.1.1 #77

Closed ikeuchy closed 6 years ago

ikeuchy commented 6 years ago

Has the usage changed in v1.1.1?

When changed from v1.1.0 to v1.1.1, the result of the following example changed: https://github.com/bd2kccd/py-causal/blob/development/example/py-causal%20-%20Bootstrapping%20GFCI%20Continuous%20in%20Action.ipynb

The result of tetrad.getEdges() in v1.1.0:

'Sympathy o-> Impact [Impact <-o Sympathy]:1.0000;', 'Sympathy --> TangibilityCondition [Sympathy --> TangibilityCondition nl pd]:1.0000; nl pd']

The result of tetrad.getEdges() in v1.1.1:

['AmountDonated o-o Sympathy', 'Sympathy o-> Impact', 'Sympathy --> TangibilityCondition']

chirayukong commented 6 years ago

We changed the parameters; so, you can not only do bootstrapping but also resample without replacement. Plus, you can specify the size of resamples. v1.1.0 bootstrapSampleSize = 5, bootstrapEnsemble = 0 v1.1.1 numberResampling = 5, resampleSize = 94, # new parameter resamplingWithReplacement = True, # new parameter, (default value: True) resamplingEnsemble = 0

Note: I need to update examples, though.

ikeuchy commented 6 years ago

Thank you for answering. I will try it.