search

bd808 / python-iptools

A few useful functions and objects for manipulating ip addresses in python.
http://python-iptools.readthedocs.org/
BSD 2-Clause "Simplified" License
70 stars 17 forks source link

Travis CI: Add Python 3.6 and 3.7 to the testing #22

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

@bd808 Your review please.

bd808 commented 5 years ago

@cclauss The pep8/flake8 fix looks good. I think you may have missed my other comment:

The new versions should be added to tox.ini as well. See https://travis-ci.org/bd808/python-iptools/jobs/464168554: "Matching undeclared envs is deprecated. Be sure all the envs that Tox should run are declared in the tox config."

The fix should be as easy as adding py36, py37 to the envlist in tox.ini.

cclauss commented 5 years ago

Are we all good?

bd808 commented 5 years ago

Thanks @cclauss!