search

bd82 / regexp-to-ast

MIT License
27 stars 11 forks source link

add support for lookbehind and negative lookbehind #129

Closed luiz290788 closed 1 year ago

luiz290788 commented 2 years ago

@bd82 any chance to have my PR merged? I would like to add support to lookbehind to avoid warnings in chevrotain

bd82 commented 1 year ago

Hello @luiz290788

I want to merge this package into the main Chevrotain's mono repo. Perhaps it would be best to re-create and merge your PR after I've done so. So:

  1. it would be easier to test E2E.
  2. no unneeded maintenance on a repo I intend to archive (e.g failing release process / updating build process).
luiz290788 commented 1 year ago

@bd82 do you need any help to merge the package into Chevrotain? I can help you with that.

bd82 commented 1 year ago

do you need any help to merge the package into Chevrotain? I can help you with that.

@luiz290788 that would be awesome 👍 Try to old add it as is right now with minimal changes, I will later try to convert it to TypeScript.

luiz290788 commented 1 year ago

I've finally started moving the package to inside chevrotain.

bd82 commented 1 year ago

Hello @luiz290788

regexp-to-ast is not part of the main Chevrotain repo. You can re-create your PR there (its in typescript now) if you have free time.

Cheers.