[SW-562] update unit test skipif condition for mac-related issues

bdaiinstitute / spatialmath-python

Create, manipulate and convert representations of position and orientation in 2D or 3D using Python

MIT License

497 stars 82 forks source link

[SW-562] update unit test skipif condition for mac-related issues #102

Closed jcao-bdai closed 9 months ago

jcao-bdai commented 10 months ago

Update several unit tests' skipif conditions, as a follow-up to https://github.com/bdaiinstitute/spatialmath-python/pull/96

background: tkinter issue on mac https://github.com/actions/setup-python/issues/649

Some example traces taken from the build-test workflow for this PR:

(mac-latestos, 3.11): tests/base/test_graphics.py .............
(mac-latestos, 3.7): tests/base/test_graphics.py sssssssssssss

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7195f3d) 75.62% compared to head (1918b79) 75.62%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #102 +/- ## ======================================= Coverage 75.62% 75.62% ======================================= Files 24 24 Lines 5132 5132 ======================================= Hits 3881 3881 Misses 1251 1251 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

amessing-bdai commented 9 months ago

I don't know that we want to remove Mac \w 3.7-3.10 from running any unit tests. Just the ones with tkinter where there is a known bug upstream.

jcao-bdai commented 9 months ago

I don't know that we want to remove Mac \w 3.7-3.10 from running any unit tests. Just the ones with tkinter where there is a known bug upstream.

@amessing-bdai updated the code and the PR description (with traces from latest build-test workflow). could you please take another look? thanks!