search

bdaiinstitute / spatialmath-python

Create, manipulate and convert representations of position and orientation in 2D or 3D using Python
MIT License
497 stars 82 forks source link

Standardizing tolerance uses #104

Closed jcao-bdai closed 9 months ago

jcao-bdai commented 9 months ago

Update additional cases of tol(erance) usages in code. As an intial pass, this PR only ensures that tolerance, when provided, should be passed to sub-routine when applicable.

In a follow-up, the default values and some tolerance implementation details may also be standardized.

jcao-bdai commented 9 months ago

Looks good to me, are we sure this is getting full coverage of all the tolerancing in the repo?

I did several passes of searching through the repo - with the second commit 619a5b396feb411f275a7b97f4429f532f895bc4, it should be full coverage now.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f57437a) 75.62% compared to head (619a5b3) 75.62%.

Files Patch % Lines
spatialmath/base/vectors.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #104 +/- ## ======================================= Coverage 75.62% 75.62% ======================================= Files 24 24 Lines 5132 5132 ======================================= Hits 3881 3881 Misses 1251 1251 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.