bdaiinstitute / spatialmath-python

Create, manipulate and convert representations of position and orientation in 2D or 3D using Python
MIT License
497 stars 82 forks source link

Bounds on acos usages; fix a couple of links in readme #108

Closed jcao-bdai closed 9 months ago

jcao-bdai commented 9 months ago

This is a first pass for the task "Bounds on acos and other functions with bounded domains", with focus on acos and asin usages.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a0bb12f) 76.47% compared to head (811ac8d) 77.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #108 +/- ## ========================================== + Coverage 76.47% 77.04% +0.56% ========================================== Files 24 24 Lines 5136 5136 ========================================== + Hits 3928 3957 +29 + Misses 1208 1179 -29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

petercorke commented 9 months ago

I have a problem with the fix for log since s can be negative, so the s/|q| should be bounded in the range [-1, 1]. I think the other fixes are ok.