bdaiinstitute / spatialmath-python

Create, manipulate and convert representations of position and orientation in 2D or 3D using Python
MIT License
497 stars 82 forks source link

Issues #101: SpatialInertia.__add__ method fix and test #109

Closed jcao-bdai closed 9 months ago

jcao-bdai commented 9 months ago

Fix issue https://github.com/bdaiinstitute/spatialmath-python/issues/101 identified by Loïc Niederhauser (@niederha).

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a0bb12f) 76.47% compared to head (612712d) 76.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #109 +/- ## ========================================== + Coverage 76.47% 76.84% +0.36% ========================================== Files 24 24 Lines 5136 5136 ========================================== + Hits 3928 3947 +19 + Misses 1208 1189 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

niederha commented 9 months ago

Thanks! Seems to work, I indeed didn't understand the code right as well, so thanks for commiting and sparing me a costly investigation. While we're on this piece of code I made a minor comment. Otherwise sounds good to me.