bdaiinstitute / spatialmath-python

Create, manipulate and convert representations of position and orientation in 2D or 3D using Python
MIT License
519 stars 84 forks source link

Publish new version and update GitHub #59

Closed Tobias-Fischer closed 1 year ago

Tobias-Fischer commented 2 years ago

Hi @petercorke, We are trying to get the RTB to work with emscripten-forge (which compiles into WebAssembly). @wolfv noticed that the geom2d.py file on pypi contains a weird import:

from ssl import ALERT_DESCRIPTION_HANDSHAKE_FAILURE

Which causes trouble on emscripten-forge. I then noticed that the GitHub repo is out-of-sync (still on version 1.0.0, whereas pypi is at 1.0.1). Is there any chance to remove this odd import, publish a new version 1.0.2, and update the repo?

Many thanks, Tobi /cc @jhavl @wolfv

petercorke commented 2 years ago

Hi Tobi,

I’ll fix this over the weekend. I have something weird in my VCS setup, occasionally adds random imports at top of files.

Peter

On 21 Oct 2022, at 1:46 pm, Tobias Fischer @.***> wrote:

Hi @petercorke https://github.com/petercorke, We are trying to get the RTB to work with emscripten-forge (which compiles into WebAssembly). @wolfv https://github.com/wolfv noticed that the geom2d.py file on pypi contains a weird import:

from ssl import ALERT_DESCRIPTION_HANDSHAKE_FAILURE Which causes trouble on emscripten-forge. I then noticed that the GitHub repo is out-of-sync (still on version 1.0.0, whereas pypi is at 1.0.1). Is there any chance to remove this odd import, publish a new version 1.0.2, and update the repo?

Many thanks, Tobi /cc @jhavl https://github.com/jhavl @wolfv https://github.com/wolfv — Reply to this email directly, view it on GitHub https://github.com/petercorke/spatialmath-python/issues/59, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2BIUWJ7EDHBCC4LYK2YSLWEH7XVANCNFSM6AAAAAARKXKJXA. You are receiving this because you were mentioned.

petercorke commented 2 years ago

@Tobias-Fischer fixed now and on PyPI. Internet crapped out on me, so only the wheel file got through. Let me know if you need the zip file.

wolfv commented 2 years ago

I think the source dist would be preferred. We can also take it from GitHub if you make the tag.

petercorke commented 2 years ago

@wolfv the source distro is there now as release 1.0.3.

wolfv commented 2 years ago

awesome!

Tobias-Fischer commented 2 years ago

Thanks @petercorke!

wolfv commented 2 years ago

It works -- here is a version that runs in the browser and also plots some nice diagrams from the docs :) Only downside is that it's a 70Mb download.

https://wolfv.github.io/try-spatialgeometry/lab?path=spatialmath_demo.ipynb

Btw. I saw that you looked at scikit-geometry for Polygon functions. Unfortunately I haven't found much time to maintain it recently, but would be happy to push a little bit on it to make it easy to install via pip as well.

petercorke commented 2 years ago

Thanks Wolf. I am super excited about WASM. Is the 70Mb just for SMTB, or does that include dependencies like MPL and NumPy?

Sorry, I’d forgotten about scikit. I think I ended up using Matplotlib functionality for this, to reduce the number of dependencies that I have.

Peter

On 23 Oct 2022, at 7:12 pm, Wolf Vollprecht @.***> wrote:

It works -- here is a version that runs in the browser and also plots some nice diagrams from the docs :) Only downside is that it's a 70Mb download.

https://wolfv.github.io/try-spatialgeometry/lab?path=spatialmath_demo.ipynb https://wolfv.github.io/try-spatialgeometry/lab?path=spatialmath_demo.ipynb Btw. I saw that you looked at scikit-geometry for Polygon functions. Unfortunately I haven't found much time to maintain it recently, but would be happy to push a little bit on it to make it easy to install via pip as well.

— Reply to this email directly, view it on GitHub https://github.com/petercorke/spatialmath-python/issues/59#issuecomment-1288047241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2BIUUXANZDPDDGAU2M6CDWETXNPANCNFSM6AAAAAARKXKJXA. You are receiving this because you were mentioned.

wolfv commented 2 years ago

Yes, the 70 mb contain everything including matplotlib and numpy.

No worries, happy that you found a solution with fewer dependencies.

petercorke commented 2 years ago

Hi @wolfv , chatting with @jhavl it seems like 30Mb of that is scipy and I can remove those dependencies with a few simple tweaks. Just need to test and push.