search

bdaiinstitute / spatialmath-python

Create, manipulate and convert representations of position and orientation in 2D or 3D using Python
MIT License
519 stars 84 forks source link

[SW-237] Raises error if a number of arguments besides 1 and 3 are passed in to SE3 constructors #84

Closed bhung-bdai closed 1 year ago

bhung-bdai commented 1 year ago

Decided not to assign default args in the event of something like (x, y) being passed in because default values aren't specified

bhung-bdai commented 1 year ago

I've went ahead and added two tests, confirming they both work with the locally built package.

myeatman-bdai commented 1 year ago

For posterity, the reason for this change was that you could invoke the SE3 constructor as so SE3(1.0, 0.0) and get uninitialized values for the internal data.