bdaiinstitute / spot_ros2

ROS 2 driver package for Boston Dynamics' Spot
Other
175 stars 61 forks source link

[N/A] Workaround automatic power off on rollover #445

Closed mhidalgo-bdai closed 3 months ago

mhidalgo-bdai commented 3 months ago

Change Overview

When the robot rolls over to battery change pose, it powers off automatically. That can result in the otherwise successful battery change pose command to be overridden. This patch is a best-effort approach to try and cope with this. It is a workaround, as there is currently no way to unequivocally differentiate a true override from an incidental one.

Testing Done

On real hardware, downstream.

mhidalgo-bdai commented 3 months ago

Looks like spot_ros2/spot_ros2/spot_driver/test/pytests/test_ros_interfaces.py::SpotDriverTest::test_robot_command_goal_complete would also need to be updated with the new argument

Should be good now.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10255533613

Details


Files with Coverage Reduction New Missed Lines %
spot_ros2/spot_ros2/spot_driver/spot_driver/spot_ros2.py 363 45.35%
<!-- Total: 363 -->
Totals Coverage Status
Change from base Build 10184412009: 0.08%
Covered Lines: 1910
Relevant Lines: 3608

💛 - Coveralls