[Hotfix] spot ros2 control controller manager issue

bdaiinstitute / spot_ros2

ROS 2 driver package for Boston Dynamics' Spot

Other

185 stars 63 forks source link

[Hotfix] spot ros2 control controller manager issue #472

Closed tcappellari-bdai closed 2 months ago

tcappellari-bdai commented 2 months ago

Change Overview

Somehow adding the copyright comment in the package.xml caused the controller manager to be unable to launch properly (services would just hang and couldn't be called)

Testing Done

Please create a checklist of tests you plan to do and check off the ones that have been completed successfully. Ensure that ROS 2 tests use domain_coordinator to prevent port conflicts. Further guidance for testing can be found on the ros utilities wiki.

amessing-bdai commented 2 months ago

@tcappellari-bdai Did you put the copyright before or after the <?xml ... >? It needs to go after

tcappellari-bdai commented 2 months ago

@tcappellari-bdai Did you put the copyright before or after the <?xml ... >? It needs to go after

~it was after~ it was not enough after

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10725515316

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 51.314%

Totals
Change from base Build 10708433200:	0.1%
Covered Lines:	1914
Relevant Lines:	3730