Okay, so I glanced at the existing code and copy-pasted some of the infrastructure over from the bdai repo, which includes:
pre-commit hooks: including black and ruff (not a lot of code yet, don't want to worry too much about it right now), and mypy (in disabled form)
.gitignore: with Naoki's existing stuff at the bottom
pyproject.toml - boiler plate stuff, upped Python version from 3.9 to 3.10 + one big issue (below).
The biggest issue I see right now (from the perspective of "I'd like to move everything over to bdai eventually"): we can't use conda, and the current dependencies instructions in the Readme makes me think this is going to be a problem. I'd like to see a pip installable list in pyproject.toml or another solution - with everything else going on, might as well Dockerize (but if you do, you would still need the dependencies list).
Okay, so I glanced at the existing code and copy-pasted some of the infrastructure over from the
bdai
repo, which includes:black
andruff
(not a lot of code yet, don't want to worry too much about it right now), andmypy
(in disabled form).gitignore
: with Naoki's existing stuff at the bottompyproject.toml
- boiler plate stuff, upped Python version from 3.9 to 3.10 + one big issue (below).The biggest issue I see right now (from the perspective of "I'd like to move everything over to
bdai
eventually"): we can't useconda
, and the current dependencies instructions in the Readme makes me think this is going to be a problem. I'd like to see apip install
able list inpyproject.toml
or another solution - with everything else going on, might as well Dockerize (but if you do, you would still need the dependencies list).