Update pre-commit config and clear errors

bdaiinstitute / vlfm

The repository provides code associated with the paper VLFM: Vision-Language Frontier Maps for Zero-Shot Semantic Navigation (ICRA 2024)

http://naoki.io/portfolio/vlfm.html

MIT License

194 stars 14 forks source link

Update pre-commit config and clear errors #12

Closed jiuguangw closed 11 months ago

jiuguangw commented 11 months ago

Updated pre-commit config to match bdai repo
Did chmod -x on a few files with shebang but not marked as executable
Various other auto-formatting. There was something wrong with @naokiyokoyama 's local setup and his pre-commit was never fully able to clear CI.

With these changes, I believe vlfm can now be merged into bdai with a trivial

git subtree add --prefix projects/vlfm https://github.com/bdaiinstitute/vlfm main --squash

bernadettekb commented 11 months ago

Thanks @jiuguangw ! Looks great - why is this happening though?

ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device

jiuguangw commented 11 months ago

Thanks @jiuguangw ! Looks great - why is this happening though?

ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device

This is the reason I put up the other Docker PR - the dependencies are too complex to rely on GitHub Actions to install by itself. I consolidated all the relevant packages into a pre-built Docker, which will solve the spacing issue here as well as reduce build time by 90%.

kashton-bdai commented 11 months ago

I did get this error when doing the pre-commit stuff but it still seems to work ok: mypy.....................................................................Failed

hook id: mypy
exit code: 1

vlfm/vlm/grounding_dino.py:64: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str") [assignment]

naokiyokoyama commented 11 months ago

My pre-commit wasn't working because I had installed frontier_exploration by manually cloning it and installing inside this repo locally, which results in ruff changing the way it should be ordered when importing it with other packages at the top of a Python script. So when I linted it locally, it would be different from when it was linted in the CI

bernadettekb commented 11 months ago

I did get this error when doing the pre-commit stuff but it still seems to work ok: mypy.....................................................................Failed

hook id: mypy

exit code: 1

vlfm/vlm/grounding_dino.py:64: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str") [assignment]

Explain mypy / the use of it our repo to Katrina - she's fixing mypy errors for her local changes.