Closed jiuguangw closed 11 months ago
Thanks @jiuguangw ! Looks great - why is this happening though?
ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device
Thanks @jiuguangw ! Looks great - why is this happening though?
ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device
This is the reason I put up the other Docker PR - the dependencies are too complex to rely on GitHub Actions to install by itself. I consolidated all the relevant packages into a pre-built Docker, which will solve the spacing issue here as well as reduce build time by 90%.
I did get this error when doing the pre-commit stuff but it still seems to work ok: mypy.....................................................................Failed
vlfm/vlm/grounding_dino.py:64: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str") [assignment]
My pre-commit wasn't working because I had installed frontier_exploration by manually cloning it and installing inside this repo locally, which results in ruff changing the way it should be ordered when importing it with other packages at the top of a Python script. So when I linted it locally, it would be different from when it was linted in the CI
I did get this error when doing the pre-commit stuff but it still seems to work ok: mypy.....................................................................Failed
- hook id: mypy
- exit code: 1
vlfm/vlm/grounding_dino.py:64: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str") [assignment]
Explain mypy / the use of it our repo to Katrina - she's fixing mypy errors for her local changes.
bdai
repochmod -x
on a few files with shebang but not marked as executableWith these changes, I believe
vlfm
can now be merged intobdai
with a trivialgit subtree add --prefix projects/vlfm https://github.com/bdaiinstitute/vlfm main --squash