Closed bluecereal closed 5 years ago
@bluecereal I don't think you gave me editor access for your PR so I created a branch of my own with the update. make that changes to your PR and then we can merge. I can write the test later :smile:
Make sure to resolve merge conflict too :D. also can you give me editor permission so I can write tests and stuff
you should have edit permissions on this PR already since this is your repository, i think.
i didnt see your changes until i had already pushed mine to my fork. i think if we just keep what you did then things will be perfect, so just ignore what i did and merge your changes.
Alright, imma close it and open the other PR
there are no tests because i dont know anything about tests