search

bdauvergne / python-oath

Python implementation of HOTP, TOTP and OCRA algorithms from OATH
BSD 3-Clause "New" or "Revised" License
128 stars 35 forks source link

Docs sync #28

Closed kousu closed 5 years ago

kousu commented 8 years ago

https://github.com/bdauvergne/python-oath/blob/172852cb9f245875686c4d5e525a304315b93c4b/oath/_hotp.py#L53 and https://github.com/bdauvergne/python-oath/blob/172852cb9f245875686c4d5e525a304315b93c4b/oath/_totp.py#L32 disagree about legal formats. 'hex40' is not allowed.

bdauvergne commented 8 years ago

I think I fixed it, can you confirm ?

kousu commented 8 years ago

They match now, but your code also has a 'dec' option that's not listed, too. :)

Why did you rename 'hex40' to 'hex-notrunc'? 'hex40' matches the 'dec' pattern, and I find it more readable.

bdauvergne commented 8 years ago

Sorry I really don't remember :) Feel free to provide a PR for dec or restore the possibility of hex40.

bdauvergne commented 5 years ago

No news good news.