simplified HOTP operations using struct

bdauvergne / python-oath

Python implementation of HOTP, TOTP and OCRA algorithms from OATH

BSD 3-Clause "New" or "Revised" License

128 stars 35 forks source link

simplified HOTP operations using struct #9

Closed dnet closed 10 years ago

dnet commented 10 years ago

Three functions of the hotp module performed such format conversions "manually" that are provided by the struct module. The unit tests ran fine, the code is shorter and IMHO more readable -- and could be even faster (no unnecessary modulos and intermediate formats), although I haven't measured that.

bdauvergne commented 10 years ago

Thank you !