search

bdbcat / oesenc_pi

GNU General Public License v2.0
10 stars 17 forks source link

flatpak: strip excessively large tarball. #100

Closed leamas closed 3 years ago

leamas commented 3 years ago

The flatpak tarball is current 7.6M whereas other architectures are 700-800Kb. The reason is the debugging symbols which are not stripped from the library.

Enclosed patch strips the tarball, bringing it to the same size as the others. Devs in need of debugging symbols might run into troubles, but the 7.6 MB price is just to high for this benefit.

rgleason commented 3 years ago

I suppose VDR_pi should be updated accordingly for flatpak, stripping symbols? I assume this does work?

leamas commented 3 years ago

@rgleason : yes

rgleason commented 3 years ago

Alec what I have now for vdr_pi locally is

id: org.opencpn.OpenCPN.Plugin.VDR
runtime: org.opencpn.OpenCPN
runtime-version: master
sdk: org.freedesktop.Sdk//18.08
build-extension: true
separate-locales: false
appstream-compose: false
modules:
    - name: VDR
      no-autogen: true
      cmake: true
      build-options:
          cflags: -fPIC
          cxxflags: -fPIC -DFLATPAK
      strip: true
      config-opts:
          - -DPREFIX:PATH=/app/extensions/VDR
      sources:
          - type: git
            url: ..
            branch: master

Without the "post_install" stuff and without this at the end of "sources"

          - type: file
            path: oeserverd
          - type: file
            # originally libusb-0.1.so.4.1.1, built from  libusb-0.1.6
            path: libusb-0.1.so.4

Will this be ok now?