Do not override CMAKE_INSTALL_PREFIX if PREFIX not set

bdbcat / oesenc_pi

GNU General Public License v2.0

10 stars 17 forks source link

Do not override CMAKE_INSTALL_PREFIX if PREFIX not set #35

Closed nohal closed 4 years ago

nohal commented 5 years ago

If PREFIX is set, CMAKE_INSTALL_PREFIX is already modified by https://github.com/bdbcat/oesenc_pi/blob/master/CMakeLists.txt#L43, setting it to /bin by default is wrong and not in line with what is used everywhere else.

This should not be an issue for packaging neither as debhelper sets CMAKE_INSTALL_PREFIX to /bin automagically when it packages a cmake project on Launchpad.

leamas commented 4 years ago

@nohal: I concur. CMAKE_INSTALL_PREFIX should be possible to set by users.

Filed #77, which is this fix + related updates to the ci scripts.