search

bdbcat / oesenc_pi

GNU General Public License v2.0
10 stars 17 forks source link

Mac: Installation paths includes build environment #37

Closed leamas closed 4 years ago

leamas commented 5 years ago

On Mac, the result of make install seemingly includes the build environment. For example, one path looks like

oesenc_pi-1.2.0-1_darwin-10.13.3/Users/travis/build/leamas/oesenc_pi/build/OpenCPN.app/Contents/PlugIns/liboesenc_pi.dylib rep

Obviously, this makes no sense. Having elements from both the travis build user and my userid creates serious problems to have reproducible results. This might have slipped through the net because the only artifact from the mac build so far has been the dmg file, and this does not suffer from this.

A simple make install on a macos machine should reveal the complete truth....

leamas commented 5 years ago

At a closer look the culprit seems to be the file cmake/PluginInstall.cmake. It contains lines like

INSTALL(TARGETS ${PACKAGE_NAME} RUNTIME LIBRARY DESTINATION ${CMAKE_BINARY_DIR}/OpenCPN.app/Contents/SharedSupport/plugins)

i. e., the source path is part of the destination. This is clearly wrong, but I have no idea how to fix it.

leamas commented 4 years ago

Fixed in current code. Closing