search

bdbcat / oesenc_pi

GNU General Public License v2.0
10 stars 17 forks source link

Ci 1751: Fix macos installation paths #67

Closed leamas closed 4 years ago

leamas commented 4 years ago

It actually turns out that I seem to have somehow dropped these patches also in my oesenc.

This seems to clean up the paths here. A view of the package contents is available at https://cloudsmith.io/~alec-leamas/repos/opencpn-plugins-unstable/packages/detail/raw/oesenc-darwin-10.13.6-tarball/1.2.0.3.1c33e62/#files.

(The history was rewritten before making this PR).

This PR is against the ci branch.

leamas commented 4 years ago

I forgot to mention that is two commits on top of the ci branch.

bdbcat commented 4 years ago

Alec... I did not have the nerve to merge this as-is. Yikes.... Manually made the updates to my repo.

leamas commented 4 years ago

Yes, I figured. Handling PRs to non-master branch is a mess.

Since master is more or less in a frozen state now: perhaps you should configure the ci branch as the default one? This should make the PRs against ci straight-forward.

Sorry for not making these tests earlier. My macos VM has been in a sad state. It's now resurrected, so that part is no problem. I'll try to do some more tests later.

leamas commented 4 years ago

Fixed. Closing.

rgleason commented 4 years ago

What does building buster do? Commented it out. --Is it for deb builds? Also I think I am going to put mingw back in since OpenCPN still has it. OK?

leamas commented 4 years ago

You are free to put whatever you want back, it's your show. I just mention what I think has a lower priority of time or builders are scarce.

Besides the ubuntu/x86_64 for desktops we also build for raspberrry pie. IMHO, the main focus should be Raspbian/armhf. However, it is also possible to run official Debian on Rpi, buster/armel is the current release. It's @bdbcat who have added the RPi builds, talk to him about it.

rgleason commented 4 years ago

Thanks, buster can easily be added back later, 2 raspbian/armhf are in and working. now following the gtk3 commits.