bdbcat / oesenc_pi

GNU General Public License v2.0
10 stars 17 forks source link

Gtk3 #70

Closed leamas closed 4 years ago

leamas commented 4 years ago

It turns out that building against wxgtk3 basically is about using update-alternatives to set wx-config to point the the gtk3 version, simple enough.

Set PKG_TARGET to the new ubuntu-gtk3 value, and update build scripts.

While on it, mute warnings from cmake and fix a nasty windows bug (last commit). Also, restore the CLOUDSMITH_STABLE_REPO and CLOUDSMITH_UNSTABLE_REPO used elsewhere to define the cloudsmith deployment repos.

leamas commented 4 years ago

The build error looks OK, same code passed one of the other travis builders. Probably some arm hardware which refused to handle the load.

rgleason commented 4 years ago

I don't really understand the impact of this

These packages are available in trusty+. The base-files fallback is for optional packages available in later releases.

...and I have no idea what happens with various env here

but won't these removals affect plugins such as weatherfax, rtlsdr, etc https://github.com/bdbcat/oesenc_pi/pull/70/commits/357da06b9ee89f5a0d4404dfb513450c1d89c3ff libwxsvg-dev | base-files, portaudio19-dev,

...or does each plugin carry its own burden of libs

leamas commented 4 years ago

I don't really understand the impact of this.

It basically says that this control file is valid from trusty and upwards. Since there is no way to express that package is optional we are using constructs like libunarr-dev | base-files (<< 11), which means that either install unarr-dev or, on a debian version < 11 (bullseye) just use base-files. In short: on versions before 11, don't install anything, otherwise install libunarr-dev.

but won't these removals affect plugins such as...

Doubt that. Just try, you could re-add them if there is a build error.

Overall, the problem with that list is that it is too long. Installing unused packages takes time.

rgleason commented 4 years ago

Ok, but I know from building weatherfax as a standalone compile (not in-liine with O) that portaudio is absolutely needed, and same with rtlsdr and one other plugin... forgot which one.

leamas commented 4 years ago

In which case you add it for weahterfax. But there is no need for other plugins, which doesn't use, to carry this dependency.

It is expected that different plugins adds specific dependencies