bdbcat / oesenc_pi

GNU General Public License v2.0
10 stars 17 forks source link

Android builds of PI #99

Closed rgleason closed 3 years ago

rgleason commented 3 years ago

Dave is it time to add the android builds to plugins? IE How mature is this at this point? Sean wrote and is interested in getting this going on all his plugins.

rgleason commented 3 years ago

I have tried it in Watchdog, but both android seem to fail.

https://github.com/rgleason/watchdog_pi master branch

https://github.com/rgleason/watchdog_pi/runs/1064498962

https://app.circleci.com/pipelines/github/rgleason/watchdog_pi/95/workflows/1d0c6423-7033-464a-8e31-a74c0f71fafd/jobs/1092

bdbcat commented 3 years ago

Rick... I am ready to start the integration of Android build on Frontend-2. Which plugin, based on Frontend-2, is the simplest? That is, does not have much UI interaction, does not download private data, etc. Could it be VDR?

btw, your build on watchdog failed for simple reason. Read the log. The script permission needs to be +X.

rgleason commented 3 years ago

Thanks Dave, I'll check the watchdog error.

I think the best plugin to use is my fork of Jon's testplugin_pi. I will make sure you have collaboration access (sent you an invite). Jon can them move the Android build into his repository.

github.com/rgleason/vdr_pi master branch (you are a collaborator) is using your frontend1 and I will update that to make it current with your oesenc frontend and then make a PR to plugins..

Thanks

rgleason commented 3 years ago

BTW, watchdog and weather_routing flatpak isn't building very well, don't know why.

rgleason commented 3 years ago

"The script permission needs to be +X." This 126 Error trips me up every time! will do chmod.

rgleason commented 3 years ago

Error: /bin/bash: ci/circleci-build-fedora.sh: Permission denied Exited with code exit status 126

CHMOD For Windows: You must be in the actual directory for the commands to work! Also git status must show file changed. git update-index --add --chmod=+x git commit -m 'Make executable'

bdbcat commented 3 years ago

Rick... Any progress on VDR Frontend-1 for Android?

bdbcat commented 3 years ago

Rick/Jon... Frontend-2 for testplugin_pi has been adapted for Android builds. The new code is in Rick's repo, in branch "android_ci". There is still some problem with the cloudsmith-upload.sh script, which I did not modify. Perhaps this is due to building from a branch other than "master", and so will self correct when the android_ci branch is merged....maybe.

Also note, on this plugin, some source files needed touch-up for Android build. Nothing serious, and I expect we will see more of this sort of thing as we adapt more plugins to Android. Please let me know when this patch has been merged, and a correct tarball build is available in cloudsmith for import testing on actual Android hardware.

rgleason commented 3 years ago

"Any progress on VDR Frontend-1 for Android?" Sorry, I will do that next, after a day sail. I will checkout testplugin thanks.

rgleason commented 3 years ago

RE: testplugin_pi branch: android-ci
That is great that you can make a new branch, I did not know that. This new branch appears to have all the permissions needed to build, in travis, appveyor and circleci. Just the flatpak and android-armhf builds are failing.

android-armhf failures are:

+ cp xml.tmp /home/circleci/project/build/testplugin_pi-1.0.132.1-android-armhf-16.xml
cp: cannot create regular file '/home/circleci/project/build/testplugin_pi-1.0.132.1-android-armhf-16.xml': Permission denied
+ cat /home/circleci/project/build/testplugin_pi-1.0.132.1-android-armhf-16.xml

and

++ pwd
+ cur_dir=/home/circleci/project
+ gunzip -f /home/circleci/project/build/testplugin_pi-1.0.132.1-android-armhf-16.tar.gz
gzip: /home/circleci/project/build/testplugin_pi-1.0.132.1-android-armhf-16.tar: Permission denie

Yet you have put a chmod in the script to fix this....

The flatpak failure looks like one I've been getting in watchdog recently too.

rgleason commented 3 years ago

In Cloudsmith Opencpen testplugin-alpha there are recent builds of v1.0.132 from your branch android-ci one of them is a tarball for android-arm64.

Do you want me to make a PR to plugins to add just that tarball?

bdbcat commented 3 years ago

The tarball in cloudsmith now is not correct. Still working on the permission question. I'll let you know....

rgleason commented 3 years ago

Ok, I just pulled your branch down, incremented version and pushed it back up.

Will stop now

bdbcat commented 3 years ago

Rick... All fixed up in android_ci build. The cloudsmith tarballs in "testplugin-alpha" look good. What is your plan to merge this branch? Will you do it, or Jon? Anyway, if you could PR the newly built android tarballs into the master catalog, I can do the final checks. Please note that Android works mainly with the master catalog, and requires manual config editing to address the Beta and Alpha catalogs. This was done to simplify the UI on Android, with its limited screen space. Thanks Dave

rgleason commented 3 years ago

Dear Dave, Thank you! It looks like flatpak is working too! Thanks. I will merge it into my master and make a PR to Jon's repository. Then Push it to Plugins repository. Then I will be able to update other plugins to include android.

Tomorrow I will try to do vdr_pi. (We rigged the sails again with friends and went for a wonderful sail today)

bdbcat commented 3 years ago

Rick... Sounds like Jon will be offline for some time. When you have merged android_ci to your master and rebuilt, you should be able to pull the tarballs from Cloudsmith and update the plugin master catalog, all before Jon merges your changes to his repo. This would help me validate the Android system. Thanks Dave

rgleason commented 3 years ago

Have tried to Push testplugin, but it fails, probably due to need to add android to the Actions github check. testplugin 1.0.133.0 add android fix flatpak #242

https://github.com/OpenCPN/plugins/issues/243

Let me know if you need another PR.

bdbcat commented 3 years ago

https://github.com/OpenCPN/plugins/issues/243#issuecomment-687946845

rgleason commented 3 years ago

Good that it's working now. Thank you Dave.