search

bdbergeron / BDBOAuth1Manager

OAuth 1.0a library for AFNetworking 2.x
MIT License
100 stars 35 forks source link

Multiple parameters with the same name don't work #8

Closed gauthierm closed 10 years ago

gauthierm commented 10 years ago

A NSDictionary is used in OAuthAuthorizationHeaderForMethod so if you have two query string params or two post data params with the same key the request is not signed properly.

OAuth spec lists how to handle multiple parameters with the same name in http://tools.ietf.org/html/rfc5849#section-3.4.1.3.2

bdbergeron commented 10 years ago

This is not something that I will be "fixing," because it's a non-issue as far as I'm concerned. If you feel so inclined to take it upon yourself and implement this ability, be my guest, and I will entertain any pull requests you submit. However, considering the fact that this is built on top of the AFNetworking library, you may want to take a while to understand the internals of how it builds requests and serializes parameters. You'll quickly find that it uses dictionaries throughout when dealing with request parameters. If this is something you absolutely require support for, I suggest exploring alternatives to AFNetworking.