bdebon / choiceof.dev

Developers have to cope with pretty hard choices every day. This is a collection of the most complex and funny choices. What will be yours?
https://choiceof.dev
GNU General Public License v3.0
473 stars 93 forks source link

new question: console.log('here') or debugger #120

Open HugoWith opened 1 year ago

HugoWith commented 1 year ago

What this PR is about?

👉 Adding some content to the app (new question)

if it is a new question for the website

put here the question like: "Tab or Space" 👉 console.log('here') or debugger Upload a screenshot of the question taken from your localhost environment

Screenshot 2022-11-23 at 11 08 25

Add the label: new question

Your PR will be reviewed and our CI will run some tests and checks. If everything is fine, and the joke is fun, we will merge it and your question will be available on the website 🎉


If it's a new feature

Tests

Clean Code

hexadeciman commented 1 year ago

Looks like you just found a bug :)

We need to wrap long words

bdebon commented 1 year ago

if you fix the bug in this same pr maybe I'll consider adding the question to the project eheheh

HugoWith commented 1 year ago

Let's go then 😁

hexadeciman commented 1 year ago

Let's go then 😁

I think @bdebon meant that you will need to add the code to fix the overflowing text bug in this PR, for it to be merged. Also you shouldn't remove package-lock.json

HugoWith commented 1 year ago

Let's go then 😁

I think @bdebon meant that you will need to add the code to fix the overflowing text bug in this PR, for it to be merged. Also you shouldn't remove package-lock.json

Hello @hexadeciman 😊

I understood, my bad I should have said that I was in for the fix. I added a small animation on text to avoid overlaping between the sections. Animation on font-size is changing according to the width of the screen that was already in the component. Might not be the best way to do that though.

Here is a small video showing the fix : https://share.getcloudapp.com/qGuZwR69

Here is a picture:

Screenshot 2022-11-24 at 16 39 35