bdebon / choiceof.dev

Developers have to cope with pretty hard choices every day. This is a collection of the most complex and funny choices. What will be yours?

https://choiceof.dev

GNU General Public License v3.0

473 stars 93 forks source link

fix: history.back when there is no next question + make computeNextQu… #19

Closed astahmer closed 2 years ago

astahmer commented 2 years ago

…estion stable

What this PR is about?

fix a bug with history.back, steps to reproduce:

go to localhost:4200, you get redirected to localhost:4200/question/xxx-1
click on either answer
click on next question, you get redirected to localhost:4200/question/yyy-1
click back on browser / mobile, you get redirected to localhost:4200/question/xxx-1
click back, you get redirect to localhost:4200 for a second, that's when it crashes (before this PR)
and then it redirects back to localhost:4200/question/xxx-1 (after this PR)

Tests

[ ] I have run the tests of the project. nx affected --target=test

Clean Code

[x] I made sure the code is type safe (no any)

bdebon commented 1 year ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: