bdebon / choiceof.dev

Developers have to cope with pretty hard choices every day. This is a collection of the most complex and funny choices. What will be yours?

https://choiceof.dev

GNU General Public License v3.0

473 stars 93 forks source link

feat: added style (scale) on image hover #28

Open glazk0 opened 2 years ago

glazk0 commented 2 years ago

What this PR is about?

It's a little something that will add some animation on image hover.

Here is a preview: https://gyazo.com/4a0b10345609db16e361587efbacdad7

Tests

[ ] I have run the tests of the project. nx affected --target=test

Clean Code

[X] I made sure the code is type safe (no any)

bdebon commented 2 years ago

Hey @glazk0 thanks for the contribution! I'm not sure about this feature because we are on full screen, your mouse has no possibility to avoid being on the hover zone so you ends ups with always an image zoomed-in. Furthermore, when you click, there is a little glitch where the zoomed-in effect disappear and you have a small jump of size for the image. That's a good idea but I don't know if it's needed in the project. I let the issue opened on to discuss to see if other like it.