When working on my last PR for Firefox support I noticed only popup.js was linted, and the style in content.js wasn't consistent so I couldn't lint my code there.
I didn't include this change in the previous PR because it would have messed up the diff, so here's a separate PR that replaces eslint popup.js --fix by eslint . --fix to apply to all JS files, and committed the changes. The only manual change I had to make was to remove the unused sender and sendResponse parameters to the onMessage.addListener callback.
Quick unrelated side note while I'm there, I see in things to improve in the readme that "drag and drop thumbnail should work" is not ticked, but this feature was working fine for me so maybe it's actually done? I'll let you confirm that :P
When working on my last PR for Firefox support I noticed only
popup.js
was linted, and the style incontent.js
wasn't consistent so I couldn't lint my code there.I didn't include this change in the previous PR because it would have messed up the diff, so here's a separate PR that replaces
eslint popup.js --fix
byeslint . --fix
to apply to all JS files, and committed the changes. The only manual change I had to make was to remove the unusedsender
andsendResponse
parameters to theonMessage.addListener
callback.Quick unrelated side note while I'm there, I see in things to improve in the readme that "drag and drop thumbnail should work" is not ticked, but this feature was working fine for me so maybe it's actually done? I'll let you confirm that :P