bdecentgmbh / moodle-block_dash

The interface and report builder for moodle
https://bdecent.de/dash
6 stars 4 forks source link

The namespacing levels guidelines are not follows #78

Closed mudrd8mz closed 4 years ago

mudrd8mz commented 4 years ago

Please note there are rules on the names of the directories under the classes directory. Subspaces such as configuration, data_grid and others should be moved under the "local" namespace.

https://docs.moodle.org/dev/Coding_style#Namespaces

moodledev commented 4 years ago

@mudrd8mz Fixed. just curious... is there a technical reason for this guideline or just purely convention?

mudrd8mz commented 4 years ago

The technical reason is to avoid future collisions. The first-level subspace are also used by the core subsystems (such as privacy, task etc). So plugin authors can't put random things in there - they might get into conflict with a future core subsystem.

moodledev commented 4 years ago

thanks for the explanation