search

bdecentgmbh / moodle-local_learningtools

Learning Tools provides the learner with a set of useful tools, like bookmarks or notes. 
https://bdecent.de/product/learning-tools/
GNU General Public License v3.0
3 stars 3 forks source link

consider using a string to store date formats #9

Closed danmarsden closed 2 years ago

danmarsden commented 2 years ago

https://github.com/bdecentgmbh/moodle-local_learningtools/blob/main/ltool/bookmarks/classes/bookmarkstool_filter.php#L250

many langauges display dates in different ways - for that reason moodle typically stores these values in lang files - you can use the core_langconfig file which has a bunch but you can also define your own ones in the plugin lang file as well.

here's a direct link to the core_lanconfig with examples: https://github.com/moodle/moodle/blob/master/lang/en/langconfig.php

not a blocker for approval.

stefanscholz commented 2 years ago

We have updated the date methods to moodle language pack-based. now we used the language strings instead of standard time methods.

https://github.com/bdecentgmbh/moodle-local_learningtools/blob/dev/ltool/bookmarks/classes/bookmarkstool_filter.php#L256