search

bdecentgmbh / moodle-mod_videotime

The Video Time product family is a set of plugins to integrate videos into moodle courses.
http://bdecent.de/videotime
Other
10 stars 5 forks source link

Fix video not rendered with Free version in Moodle app #26

Closed dpalou closed 2 years ago

dpalou commented 3 years ago

When using the free version, the value of "data-has-pro" is "0" (string), and that is considered true in JS. This makes the app call a WS that doesn't exist (the pro one), so it fails and the video isn't rendered.

stefanscholz commented 2 years ago

Hi Daniel,

thanks for looking into this and providing a pull request.

We don't want to officially support the app in the free version of Video Time just now. We have it on the roadmap though, after we've re-worked the way Video Time works on the app. Once that's done, we'll add official support to the free version.

Therefore I won't accept this pull request, but feel free to use it yourself, that's totally fine.

Best Stefan