bdecentgmbh / moodle-mod_videotime

The Video Time product family is a set of plugins to integrate videos into moodle courses.
http://bdecent.de/videotime
Other
10 stars 5 forks source link

Deleting course throws error when mod deft response is not installed #65

Open lonesomewalker opened 7 months ago

lonesomewalker commented 7 months ago
Stack trace: 
line 77 of /mod/videotime/plugin/live/lib.php: Error thrown
line 7970 of /lib/moodlelib.php: call to videotimeplugin_live_delete_instance()
line 301 of /mod/videotime/lib.php: call to component_callback()
line 5167 of /lib/moodlelib.php: call to videotime_delete_instance()
line 5028 of /lib/moodlelib.php: call to remove_course_contents()
line 68 of /course/delete.php: call to delete_course()

After installing Deft response i was finally able to delete.

SERIOUSLY: who glued this together?

Related to mod/videotime/plugin/live/lib.php

function videotimeplugin_live_delete_instance($id) {
    global $DB;

    $DB->delete_records('videotimeplugin_live', array('videotime' => $id));
    \block_deft\janus_room::remove('videotimeplugin_live', $id);

    return true;
}

I have seen, in latest git version this is captured with an if statement (but not for older 3.11 release).

Be honest: are you even interested to maintain this anymore?