search

bdecentgmbh / moodle-mod_videotime

The Video Time product family is a set of plugins to integrate videos into moodle courses.
http://bdecent.de/videotime
Other
10 stars 5 forks source link

Fix test issue #66

Open Ampsicora opened 7 months ago

Ampsicora commented 7 months ago

Error: core_calendar\container_test::test_delete_module_delete_events Error: Class 'block_deft\janus_room' not found

This fix #67 adding a check for the class block_deft\janus_room to exists in order to prevent a failing test

golenkovm commented 7 months ago

Thanks for raising this @Ampsicora

I's suggest to link this PR to the issue (if it doesn't exist feel free to create it). Also could you please provide the environment details this error is happening in? You can simply copy the header from your phpunit output (there are a few lines with Moodle, db, php, phpunit versions).

I wonder what is block_deft\janus_room. Is it a method that belonds to another 3rd party plugin block_deft?

I checked https://github.com/bdecentgmbh/moodle-mod_videotime/blob/master/version.php and there are no dependencies mentioned. Are there any more references to block_deft's methods in the plugin code?

Ampsicora commented 7 months ago

These are the environment details:

Moodle 4.1.8+ (Build: 20240125)
Php: 7.4.33, mariadb: 10.5.23, OS: Linux 6.2.0-1017-aws x86_64
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

block_deft seems to be a relevant class since in the code various of its methods are used and has been extended by other classes

golenkovm commented 7 months ago

This actually sounds like a dependency issue. If there are many references to block_deft plugin then it should be set as dependant in version.php and installed along with mod_videotime