search

bdefore / universal-redux

An npm package that lets you jump right into coding React and Redux with universal (isomorphic) rendering. Only manage Express setups or Webpack configurations if you want to.
MIT License
460 stars 48 forks source link

Replaced redux-async-connect with fmp-redux-async-connect #105

Closed rkotze closed 8 years ago

rkotze commented 8 years ago

Replaced redux-async-connect with fmp-redux-async-connect

Development on redux-async-connect has gone quiet.

Changes in fmp-redux-async-connect are:

redux-async-connect pull request

bdefore commented 8 years ago

@rkotze i'm not familiar with fmp. npm registry mentions a 'findmypast' user that publishes it. will the be ongoing development on this fork?

rkotze commented 8 years ago

@bdefore We need the functionality we’ve added and thought the devs using this repo would like it as well.

The author of redux-async-connect has not responded to our previous pull requests which is why we have forked our own. We will endeavour to maintain it to a certain degree.

If you would like to know more about Findmypast here is our site and tech team blog

bdefore commented 8 years ago

@rkotze thanks for bringing this up. a while back there were breaking changes in 1.0 for this library that i have not found the time to resolve. i see that your version has forked off of 0.x, so this should be an acceptable change given that the original author appears to have moved on.

one question i'd have for you is if this version could safely allow for react dependency >= 0.14 (so as to support 15.x). currently universal-redux reports a warning due to this library (and your fork) requiring the older version of react.

rkotze commented 8 years ago

@bdefore I've update the version of React in fmp-redux-async-connect. Changes

bdefore commented 8 years ago

Thanks @rkotze. Landed in 4.0.3.