search

bdejong / smartelectronix

Open source versions of all bram @ smartelectronix plugins.
GNU General Public License v3.0
251 stars 46 forks source link

Fix issue #28 #32

Closed dozius closed 7 years ago

dozius commented 7 years ago

Don't use delete to free memory allocated with _aligned_malloc.

bdejong commented 7 years ago

Hi Dan,

Oh that's why it's crashing! I haven't really been looking for the fix, just knew it was crashing @ exit.

I know this is a trivial change but could you please sign the CLA so I can merge your change?

You can find it in the repo/wiki.

Bram

On Dec 29, 2016 21:23, "Dan Smith" notifications@github.com wrote:

Don't use delete to free memory allocated with _aligned_malloc.

You can view, comment on, or merge this pull request online at:

https://github.com/bdejong/smartelectronix/pull/32 Commit Summary

  • Fix issue #28

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bdejong/smartelectronix/pull/32, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxJle4SSg960x54_YpJdsJzv31-pZwLks5rNBaigaJpZM4LX0rs .

dozius commented 7 years ago

ahem

https://github.com/bdejong/smartelectronix/graphs/contributors

Has it been too long? 😄

bdejong commented 7 years ago

Oh dear. Didn't make the connection between username and real name. Apologies.... Somehow the notification emails from GitHub now carry your real name. Will merge!

On Dec 30, 2016 12:08 AM, "Dan Smith" notifications@github.com wrote:

ahem

https://github.com/bdejong/smartelectronix/graphs/contributors

Has it been too long? 😄

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bdejong/smartelectronix/pull/32#issuecomment-269707871, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxJlf0Hulb9a8z0dD3leHlHHA7Ayk4Pks5rND2HgaJpZM4LX0rs .

dozius commented 7 years ago

:thumbsup: