search

bdelespierre / laravel-blade-linter

A simple Blade template syntax checker for Laravel
MIT License
19 stars 5 forks source link

Prefer constant over variable #2

Closed qrazi closed 4 years ago

qrazi commented 4 years ago

Ah, sorry, missed the automatic checks. And the --prefer-lowest is new to me... ':)

Minimal version of symfony/console is 5.0.0. The class constant was introduced in 5.1.0. That's why I missed it when running tests locally. I'll have a look at introducing the class constant, but it does feel a bit redundant to me in the longer run.

qrazi commented 4 years ago

Now all checks are completed. I rebased and squashed around a bit with the commits, but I think this looks OK?

bdelespierre commented 4 years ago

Looks good :ok_hand: Thanks for your contribution :+1: