bdew-minecraft / pressure

Pressure Pipes mod
18 stars 10 forks source link

Tank contents are lost on chunk load #29

Closed benstreb closed 10 years ago

benstreb commented 10 years ago

If I set up a tank such that something is ejecting a fluid into it, the tank's contents will be lost when the chunk is loaded.

To replicate: Tank 1 has a controller, one tank block, a powered tank fluid output, and 16 buckets of water (the exact number isn't important). Tank 2 has a controller, one tank block, a tank fluid input, and is filled with water. If I connect the output to the input with a high pressure pump, exit the world, and return to it, Tank 1 will be empty and Tank 2 will have 16 buckets of water in it.

Tank 1 was full of water here, but I found the fluid also disappeared if a had a creative portable tank auto-ejecting into a large tank, or a magma crucible auto-ejecting into a tank, or, sometimes, a transfer node ejecting into the tank.

bdew commented 10 years ago

Please post your forge log, if there's something going wrong with saving/loading it will probably be there.

benstreb commented 10 years ago

The only obviously relevent bit I found in the logs was this:

If that's not helpful, here's a somewhat larger sample of the log file - this spans from about the time I begin setting up the bug to logging in again and verifying that the tank has been emptied. [01:02:34] [Netty Client IO #0/INFO]: Server protocol version 1 [01:02:34] [Netty IO #1/INFO]: Client protocol version 1 [01:02:34] [Server thread/INFO]: Changing view distance to 12, from 10 [01:02:34] [Netty IO #1/INFO]: Client attempting to join with 72 mods : owneremitter@2.0.0,ExtraUtilities@1.1.0k,MineFactoryReloaded|CompatForgeMicroblock@1.7.10R2.8.0RC3,simplyjetpacks@1.1.4,TubesCore@${version},Aroma1997CoreHelper@1.0.2.9,Opis@1.2.3,autopackager@1.5.1b,AromaBackup@0.0.0.5,MineFactoryReloaded|CompatRailcraft@1.7.10R2.8.0RC3,MineFactoryReloaded|CompatMystcraft@1.7.10R2.8.0RC3,supercraftingframe@1.7.10.1,MineFactoryReloaded|CompatRP2@1.7.10R2.8.0RC3,WailaHarvestability@1.1.0,mcp@9.05,NEIAddons|Forestry@1.12.2.9,ObsidiPlates@3.0.0.18,NEIAddons|CraftingTables@1.12.2.9,MapWriter@2.1.1,NEIAddons|ExNihilo@1.12.2.9,cgo@3.0.8,FastCraft@1.9,@000,RedstoneArsenal@1.7.10R1.1.0RC1,MineFactoryReloaded|CompatAtum@1.7.10R2.8.0RC3,CodeChickenCore@1.0.3.28,MineFactoryReloaded|CompatThermalExpansion@1.7.10R2.8.0RC3,ImmibisCore@59.0.3,TorchTools@1.1.0.19,progressiveautomation@1.4.12,NEIAddons@1.12.2.9,SolarFlux@1.7.10-0.4b,Waila@1.5.4a,WTP@1.7.10-1.0.29,CoFHCore@1.7.10R3.0.0B7,bagginses@@MODVERSION@,MineFactoryReloaded|CompatAppliedEnergistics@1.7.10R2.8.0RC4,MineFactoryReloaded@1.7.10R2.8.0RC4,MineMenu@1.1.8,ThermalExpansion@1.7.10R4.0.0B6,MineFactoryReloaded|CompatBackTools@1.7.10R2.8.0RC4,MineFactoryReloaded|CompatProjRed@1.7.10R2.8.0RC3,inventorytweaks@1.59-dev-152-cf6e263,MineFactoryReloaded|CompatIC2@1.7.10R2.8.0RC3,Tubes@2.0.4,MineFactoryReloaded|CompatVanilla@1.7.10R2.8.0RC4,MineFactoryReloaded|CompatThaumcraft@1.7.10R2.8.0RC4,FML@7.10.85.1235,GreenThumb@1.1.0.3,NotEnoughItems@1.0.3.60,NEIAddons|Botany@1.12.2.9,DimensionalAnchors@59.0.2,JABBA@1.1.4,ForgeMultipart@1.1.0.310,MineFactoryReloaded|CompatExtraBiomes@1.7.10R2.8.0RC3,MineFactoryReloaded|CompatChococraft@1.7.10R2.8.0RC3,MineFactoryReloaded|CompatTwilightForest@1.7.10R2.8.0RC4,pressure@1.0.0.44,bdlib@1.5.0.31,Forge@10.13.2.1235,D3Core@1.0.0.11,MineFactoryReloaded|CompatBuildCraft@1.7.10R2.8.0RC4,inpure|core@1.7.10R1.0.0B1,MineFactoryReloaded|CompatForestry@1.7.10R2.8.0RC4,MineFactoryReloaded|CompatSufficientBiomes@1.7.10R2.8.0RC3,FlatSigns@2.0.0.17,McMultipart@1.1.0.310,StorageDrawers@1.1.7,ForgeMicroblock@1.1.0.310,Aroma1997Core@1.0.2.9,MobiusCore@1.2.3,ThermalFoundation@1.7.10R1.0.0B3 [01:02:34] [Netty IO #1/INFO]: Attempting connection with missing mods [] at CLIENT [01:02:34] [Netty Client IO #0/INFO]: Attempting connection with missing mods [] at SERVER [01:02:34] [Server thread/INFO]: [Server thread] Server side modded connection established [01:02:34] [Client thread/INFO]: [Client thread] Client side modded connection established [01:02:34] [Server thread/INFO]: Redacted[local:E:c313043b] logged in with entity id 232 at (572.7508156027036, 73.0, 201.87256266522414) [01:02:34] [Server thread/INFO]: Redacted joined the game [01:02:34] [Client thread/INFO]: 11 / 11 applied [01:02:34] [Server thread/INFO]: SERVER: MineMenu is installed. Sending server response packet [01:02:35] [Client thread/INFO]: Receiving Server Configuration... [01:02:35] [Client thread/INFO]: Received server configuration [01:02:35] [Server thread/INFO]: World changed, resetting [01:02:35] [Client thread/ERROR]: Failed to find identifier for: thermalfoundation.item.ItemLexicon@4a6ef960 [01:02:35] [Client thread/ERROR]: Failed to find identifier for: thermalexpansion.item.tool.ItemWrench@9c0f4be [01:02:35] [Client thread/ERROR]: Failed to find identifier for: thermalexpansion.item.tool.ItemIgniter@586048eb [01:02:35] [Client thread/ERROR]: Failed to find identifier for: thermalexpansion.item.ItemFlorb@2cda5432 [01:02:37] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 2478ms behind, skipping 49 tick(s) [01:02:37] [Client thread/INFO]: [INpureCore]: Get off my curb you good for nothin! (Hiding tile.mobSpawner) [01:02:37] [Client thread/INFO]: [INpureCore]: Get off my curb you good for nothin! (Hiding tile.water) [01:02:37] [Client thread/INFO]: [INpureCore]: Get off my curb you good for nothin! (Hiding tile.lava) [01:02:37] [Client thread/INFO]: [INpureCore]: Get off my curb you good for nothin! (Hiding tile.portal) [01:02:37] [Client thread/INFO]: [INpureCore]: Get off my curb you good for nothin! (Hiding tile.null) [01:02:37] [Client thread/INFO]: [INpureCore]: Get off my curb you good for nothin! (Hiding tile.fire) [01:02:37] [Client thread/INFO]: [INpureCore]: Sweeping ForgeMicroblocks under the nearest rug... [01:02:37] [Client thread/INFO]: [INpureCore]: Burying ExtraUtilities microblocks in the back yard... [01:02:38] [Client thread/INFO]: Added NEI integration [01:02:38] [Client thread/INFO]: World changed, resetting [01:02:38] [Client thread/INFO]: Available server commands: [01:02:38] [Client thread/INFO]: Mw.load: loading... [01:02:38] [Client thread/INFO]: generating block colours [01:02:38] [Client thread/INFO]: loading block colour overrides file /redacted/minecraft/config/MapWriterBlockColourOverrides.txt [01:02:38] [Client thread/INFO]: generating block map colours from textures [01:02:38] [Client thread/INFO]: created new MwTexture from GL texture id 19 (1024x1024) (1048576 pixels) [01:02:38] [Client thread/INFO]: processed 944 block textures, 4280 skipped, 63 exceptions [01:02:38] [Client thread/INFO]: loading block colour overrides file /redacted/minecraft/config/MapWriterBlockColourOverrides.txt [01:02:38] [Client thread/INFO]: saving block colours to '/redacted/minecraft/config/MapWriterBlockColours.txt' [01:02:39] [Client thread/INFO]: [CHAT] InvTweaks: Configuration loaded. [01:02:41] [AromaBackup/INFO]: [§1AromaBackup§r] Starting Backup. Server may lag for a bit! [01:02:41] [Client thread/INFO]: [CHAT] [§1AromaBackup§r] Starting Backup. Server may lag for a bit! [01:02:44] [AromaBackup/INFO]: [§1AromaBackup§r] Server Backup Done! [01:02:44] [AromaBackup/INFO]: [§1AromaBackup§r] Next scheduled backup in 30 minutes. [01:02:44] [Client thread/INFO]: [CHAT] [§1AromaBackup§r] Server Backup Done! [01:02:44] [Client thread/INFO]: [CHAT] [§1AromaBackup§r] Next scheduled backup in 30 minutes.

[01:02:52] [Server thread/INFO]: Saving and pausing game... [01:02:52] [Server thread/INFO]: Saving chunks for level 'Test'/Overworld [01:02:52] [Server thread/INFO]: Saving chunks for level 'Test'/Nether [01:02:52] [Server thread/INFO]: Saving chunks for level 'Test'/The End [01:02:52] [Server thread/INFO]: Saving chunks for level 'Test'/Underdark [01:02:59] [Netty Client IO #0/INFO]: CLIENT: Disconnected from server, enabling all click actions [01:02:59] [Netty Client IO #0/INFO]: Updating configuration files [01:02:59] [Server thread/INFO]: Stopping server [01:02:59] [Server thread/INFO]: Saving players [01:02:59] [Server thread/INFO]: Saving worlds [01:02:59] [Server thread/INFO]: Saving chunks for level 'Test'/Overworld [01:02:59] [Server thread/INFO]: Saving chunks for level 'Test'/Nether [01:02:59] [Server thread/INFO]: Saving chunks for level 'Test'/The End [01:02:59] [Server thread/INFO]: Saving chunks for level 'Test'/Underdark [01:02:59] [Server thread/INFO]: Unloading dimension 0 [01:02:59] [Server thread/INFO]: Unloading dimension -1 [01:02:59] [Server thread/INFO]: Unloading dimension 1 [01:02:59] [Server thread/INFO]: Unloading dimension -100 [01:02:59] [Server thread/INFO]: Applying holder lookups [01:02:59] [Server thread/INFO]: Holder lookups applied [01:02:59] [Client thread/INFO]: Mw.close: closing... [01:02:59] [Client thread/INFO]: waiting for 204 tasks to finish...

[01:03:01] [AromaBackup-Schedule/INFO]: Stopping Backup Schedule. [01:03:06] [Server thread/INFO]: Starting integrated minecraft server version 1.7.10 [01:03:06] [Server thread/INFO]: Generating keypair [01:03:06] [Server thread/INFO]: Injecting existing block and item data into this server instance [01:03:06] [Server thread/INFO]: Applying holder lookups [01:03:06] [Server thread/INFO]: Holder lookups applied [01:03:06] [Server thread/INFO]: Loading dimension 0 (Test) (net.minecraft.server.integrated.IntegratedServer@1568ce63) [01:03:06] [Server thread/INFO]: Loading dimension -100 (Test) (net.minecraft.server.integrated.IntegratedServer@1568ce63) [01:03:06] [Server thread/INFO]: Loading dimension 1 (Test) (net.minecraft.server.integrated.IntegratedServer@1568ce63) [01:03:06] [Server thread/INFO]: Loading dimension -1 (Test) (net.minecraft.server.integrated.IntegratedServer@1568ce63) [01:03:06] [Server thread/INFO]: Preparing start region for level 0 [01:03:07] [AromaBackup-Schedule/INFO]: Starting Backup Schedule. [01:03:07] [Server thread/INFO]: Next Backup in: 60 seconds. [01:03:07] [Server thread/INFO]: Changing view distance to 12, from 10 [01:03:07] [Netty Client IO #1/INFO]: Server protocol version 1 [01:03:07] [Netty IO #3/INFO]: Client protocol version 1 [01:03:07] [Netty IO #3/INFO]: Client attempting to join with 72 mods : owneremitter@2.0.0,ExtraUtilities@1.1.0k,MineFactoryReloaded|CompatForgeMicroblock@1.7.10R2.8.0RC3,simplyjetpacks@1.1.4,TubesCore@${version},Aroma1997CoreHelper@1.0.2.9,Opis@1.2.3,autopackager@1.5.1b,AromaBackup@0.0.0.5,MineFactoryReloaded|CompatRailcraft@1.7.10R2.8.0RC3,MineFactoryReloaded|CompatMystcraft@1.7.10R2.8.0RC3,supercraftingframe@1.7.10.1,MineFactoryReloaded|CompatRP2@1.7.10R2.8.0RC3,WailaHarvestability@1.1.0,mcp@9.05,NEIAddons|Forestry@1.12.2.9,ObsidiPlates@3.0.0.18,NEIAddons|CraftingTables@1.12.2.9,MapWriter@2.1.1,NEIAddons|ExNihilo@1.12.2.9,cgo@3.0.8,FastCraft@1.9,@000,RedstoneArsenal@1.7.10R1.1.0RC1,MineFactoryReloaded|CompatAtum@1.7.10R2.8.0RC3,CodeChickenCore@1.0.3.28,MineFactoryReloaded|CompatThermalExpansion@1.7.10R2.8.0RC3,ImmibisCore@59.0.3,TorchTools@1.1.0.19,progressiveautomation@1.4.12,NEIAddons@1.12.2.9,SolarFlux@1.7.10-0.4b,Waila@1.5.4a,WTP@1.7.10-1.0.29,CoFHCore@1.7.10R3.0.0B7,bagginses@@MODVERSION@,MineFactoryReloaded|CompatAppliedEnergistics@1.7.10R2.8.0RC4,MineFactoryReloaded@1.7.10R2.8.0RC4,MineMenu@1.1.8,ThermalExpansion@1.7.10R4.0.0B6,MineFactoryReloaded|CompatBackTools@1.7.10R2.8.0RC4,MineFactoryReloaded|CompatProjRed@1.7.10R2.8.0RC3,inventorytweaks@1.59-dev-152-cf6e263,MineFactoryReloaded|CompatIC2@1.7.10R2.8.0RC3,Tubes@2.0.4,MineFactoryReloaded|CompatVanilla@1.7.10R2.8.0RC4,MineFactoryReloaded|CompatThaumcraft@1.7.10R2.8.0RC4,FML@7.10.85.1235,GreenThumb@1.1.0.3,NotEnoughItems@1.0.3.60,NEIAddons|Botany@1.12.2.9,DimensionalAnchors@59.0.2,JABBA@1.1.4,ForgeMultipart@1.1.0.310,MineFactoryReloaded|CompatExtraBiomes@1.7.10R2.8.0RC3,MineFactoryReloaded|CompatChococraft@1.7.10R2.8.0RC3,MineFactoryReloaded|CompatTwilightForest@1.7.10R2.8.0RC4,pressure@1.0.0.44,bdlib@1.5.0.31,Forge@10.13.2.1235,D3Core@1.0.0.11,MineFactoryReloaded|CompatBuildCraft@1.7.10R2.8.0RC4,inpure|core@1.7.10R1.0.0B1,MineFactoryReloaded|CompatForestry@1.7.10R2.8.0RC4,MineFactoryReloaded|CompatSufficientBiomes@1.7.10R2.8.0RC3,FlatSigns@2.0.0.17,McMultipart@1.1.0.310,StorageDrawers@1.1.7,ForgeMicroblock@1.1.0.310,Aroma1997Core@1.0.2.9,MobiusCore@1.2.3,ThermalFoundation@1.7.10R1.0.0B3 [01:03:07] [Netty IO #3/INFO]: Attempting connection with missing mods [] at CLIENT [01:03:07] [Netty Client IO #1/INFO]: Attempting connection with missing mods [] at SERVER [01:03:07] [Client thread/INFO]: [Client thread] Client side modded connection established [01:03:07] [Server thread/INFO]: [Server thread] Server side modded connection established [01:03:07] [Server thread/INFO]: Redacted[local:E:f1372e43] logged in with entity id 10189 at (572.1435771476712, 73.0, 202.06040046601336) [01:03:07] [Server thread/INFO]: Redacted joined the game [01:03:07] [Server thread/INFO]: SERVER: MineMenu is installed. Sending server response packet [01:03:07] [Client thread/INFO]: Receiving Server Configuration... [01:03:07] [Client thread/INFO]: Received server configuration [01:03:07] [Client thread/INFO]: World changed, resetting [01:03:07] [Client thread/INFO]: Available server commands: [01:03:08] [Client thread/INFO]: Mw.load: loading... [01:03:08] [Client thread/INFO]: generating block colours [01:03:08] [Client thread/INFO]: loading block colour overrides file /redacted/minecraft/config/MapWriterBlockColourOverrides.txt [01:03:08] [Client thread/INFO]: generating block map colours from textures [01:03:08] [Client thread/INFO]: created new MwTexture from GL texture id 19 (1024x1024) (1048576 pixels) [01:03:08] [Client thread/INFO]: processed 944 block textures, 4280 skipped, 63 exceptions [01:03:08] [Client thread/INFO]: loading block colour overrides file /redacted/minecraft/config/MapWriterBlockColourOverrides.txt [01:03:08] [Client thread/INFO]: saving block colours to '/redacted/minecraft/config/MapWriterBlockColours.txt'

[01:03:09] [Server thread/INFO]: Saving and pausing game... [01:03:09] [Server thread/INFO]: Saving chunks for level 'Test'/Overworld [01:03:09] [Server thread/INFO]: Saving chunks for level 'Test'/Nether [01:03:09] [Server thread/INFO]: Saving chunks for level 'Test'/The End [01:03:09] [Server thread/INFO]: Saving chunks for level 'Test'/Underdark [01:03:10] [Netty Client IO #1/INFO]: CLIENT: Disconnected from server, enabling all click actions [01:03:10] [Netty Client IO #1/INFO]: Updating configuration files [01:03:10] [Server thread/INFO]: Stopping server [01:03:10] [Server thread/INFO]: Saving players [01:03:10] [Server thread/INFO]: Saving worlds [01:03:10] [Server thread/INFO]: Saving chunks for level 'Test'/Overworld [01:03:10] [Server thread/INFO]: Saving chunks for level 'Test'/Nether [01:03:10] [Server thread/INFO]: Saving chunks for level 'Test'/The End [01:03:10] [Server thread/INFO]: Saving chunks for level 'Test'/Underdark [01:03:11] [Server thread/INFO]: Unloading dimension 0 [01:03:11] [Server thread/INFO]: Unloading dimension -1 [01:03:11] [Server thread/INFO]: Unloading dimension 1 [01:03:11] [Server thread/INFO]: Unloading dimension -100 [01:03:11] [Server thread/INFO]: Applying holder lookups [01:03:11] [Server thread/INFO]: Holder lookups applied [01:03:11] [Client thread/INFO]: Mw.close: closing... [01:03:11] [Client thread/INFO]: waiting for 138 tasks to finish... [01:03:12] [AromaBackup-Schedule/INFO]: Stopping Backup Schedule.

If that's still not enough, I can attach the whole log, but it's pretty long so I'm not going to do that unless this doesn't help and you really think it will.

bdew commented 10 years ago

I think i (kinda) understand what's going on - If something ticks before the tank, right after it's loaded, the tank doesn't get a chance to figure out it's capacity and it's messing up it's content.

Please try with this version: http://jenkins.bdew.net/job/pressure-1.7.10/48/artifact/build/libs/pressure-mc1710-1.0.1.48.jar

benstreb commented 10 years ago

This seems to have fixed it. If anything changes, I'll let you know.