Closed knightlabs closed 9 years ago
+1. The footer is overwhelming and even more so on mobile. I'm ok with trying out losing the text in the logo.
Hey there - not sure losing the text will do it since the logo is a little taller. How about removing the logo entirely? Since the footer is anchored (I think we should keep it anchored because we do have a lot of long pages), don't think we need the logo at all.
I’m good with that too … just commenting :)
-- John Knight
e bug@knightlabs.com
c +1.202.390.8680
b btl.gs
On Mon, Jun 22, 2015 at 9:11 AM, kayaelle notifications@github.com wrote:
Hey there - not sure losing the text will do it since the logo is a little taller. How about removing the logo entirely? Since the footer is anchored (I think we should keep it anchored because we do have a lot of long pages), don't think we need the logo at all.
Reply to this email directly or view it on GitHub: https://github.com/bdgio/msol-site/issues/91#issuecomment-114097845
I think the shorter footer works much better. :+1:
Will check on prod too once it's pushed there.
Pushed to prod. Looks good. :koala:
Having been in the site for a few days, I now think that the footer is just overkill on wasting realestate – either it should be part of the main frame, or it should be significantly smaller – if you lose the MSOL text on the logo, and just have a single row-height MSOL badge icon inline with the text (and even inline the (c) right justified) then you'd have a nice single row footer; but at that point, not sure why you still wouldn't just embed it in the main frame. I'm assuming because the longer pages take forever to get down to the bottom of :)