bdharrison / wireless-dcc

Wireless DCC transmitter & reciever code
1 stars 0 forks source link

Incorrect values for FSTEST and AGCTEST in Receiver and Transmitter main.c #6

Open darrelllamm0 opened 4 years ago

darrelllamm0 commented 4 years ago

First off, thanks for offering this code. It was very helpful getting me started with some initSequence data for developing transmitters and receivers that are compatible with Airwire (quite a challenge) and Tam Valley Depot receivers and transmitters. See https://github.com/martan3d/AirMiniTransmitter and http://oscaledeadrail.com .

It might not matter, but the values of FSTEST and AGCTEST in initSequence are listed with the incorrect hex values with "" around them below: const static unsigned char initSequence[] = { 0x40, 0x2E, 0x2E, 0x0D, 0x07, 0xD3, 0x91, 0xFF, 0x04, 0x32, 0x00, 0x4B, 0x06, 0x00, 0x21, 0x6E, 0x2C, 0xBA, 0x84, 0x00, 0x23, 0x2F, 0x47, 0x07, 0x30, 0x18, 0x16, 0x6C, 0x03, 0x40, 0x91, 0x87, 0x6B, 0xFB, 0x56, 0x10, 0xE9, 0x2A, 0x00, 0x1F, 0x40, 0x00, 0x89, 0x7F, 0x63*, 0x81, 0x35, 0x09 };

The values 89 and 63 are decimal, not hex values listed in the Texas Instruments documentation. According to the documentation, FSTEST and AGCTEST are test-registers whose value should not be changed from the default. The corrected initSequence should be const static unsigned char initSequence[] = { 0x40, 0x2E, 0x2E, 0x0D, 0x07, 0xD3, 0x91, 0xFF, 0x04, 0x32, 0x00, 0x4B, 0x06, 0x00, 0x21, 0x6E, 0x2C, 0xBA, 0x84, 0x00, 0x23, 0x2F, 0x47, 0x07, 0x30, 0x18, 0x16, 0x6C, 0x03, 0x40, 0x91, 0x87, 0x6B, 0xFB, 0x56, 0x10, 0xE9, 0x2A, 0x00, 0x1F, 0x40, 0x00, 0x59, 0x7F, 0x3F, 0x81, 0x35, 0x09 };

It might be that the CC1101/CC110L ignores these values in burst mode anyway...

Again, many thanks, Darrell Lamm