Open rgrinberg opened 7 years ago
Sending the 500 is ok, sending the stack trace might ease debugging but I'm -0 on that as it's the only use case I can see.
We should be able to use the logs?
Yeah, but unfortunately looking up the logs in practice ends up being far less practical. There's either way too much logging when you run a test suite, or no useful logs at all until you remember to enable them. This PR is still useful enough for me to cherry pick on top of whatever i'm debugging however. So there's no hurry to merge it
We can discuss next time we meet, in general I don't think this is a good idea when the only use is debugging. Locally this fine of course.
Sent from my iPhone
On Aug 10, 2017, at 6:08 AM, Rudi Grinberg notifications@github.com wrote:
Yeah, but unfortunately looking up the logs in practice ends up being far less practical. There's either way too much logging when you run a test suite, or no useful logs at all until you remember to enable them. This PR is still useful enough for me to cherry pick on top of whatever i'm debugging however. So there's no hurry to merge it
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
@AnthonyMl