search

bdkjones / CodeKit

CodeKit 3 Issue Tracker
https://codekitapp.com
82 stars 5 forks source link

Browser preview replaces input attribute type value "reset" with window.location.host #627

Closed stenito closed 4 years ago

stenito commented 4 years ago

Quick, short summary: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used

Expected results: input type="reset" should stay "reset" đź‘Ť

Actual results: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used When surfing to the standard codekit preview URL the issue is there. When surfing to the external server URL directly on :5757 the issue is there. When surfing to the external server URL directly on its standard ports, there is no issue. Removing or using the ckcachecontrol variable does not change the outcome.

Screenshot from VSCode

Screenshot 2020-09-22 at 11 22 42

Screenshot from Chrome Dev tools

Screenshot 2020-09-22 at 11 18 37

Your configuration (any details about your system that you think might be relevant) OSX Catalina, Chrome Version 85.0.4183.102 (Official Build) (64-bit), Safari, FF

bdkjones commented 4 years ago

What’s the external server address you’ve entered in CodeKit’s project settings?

-Bryan

On Sep 22, 2020, at 03:06, stenito notifications@github.com wrote:

 Quick, short summary: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used

Expected results: input type="reset" should stay "reset" đź‘Ť

Actual results: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used When surfing to the standard codekit preview URL the issue is there. When surfing to the external server URL directly on :5757 the issue is there. When surfing to the external server URL directly on its standard ports, there is no issue. Removing or using the ckcachecontrol variable does not change the outcome.

Screenshot from VSCode

Screenshot from Chrome Dev tools

Your configuration (any details about your system that you think might be relevant) OSX Catalina, Chrome Version 85.0.4183.102 (Official Build) (64-bit), Safari, FF

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

stenito commented 4 years ago

It’s http://reset/

Steven

On 22 Sep 2020, at 17:30, Bryan Jones notifications@github.com wrote:

 What’s the external server address you’ve entered in CodeKit’s project settings?

-Bryan

On Sep 22, 2020, at 03:06, stenito notifications@github.com wrote:

 Quick, short summary: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used

Expected results: input type="reset" should stay "reset" đź‘Ť

Actual results: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used When surfing to the standard codekit preview URL the issue is there. When surfing to the external server URL directly on :5757 the issue is there. When surfing to the external server URL directly on its standard ports, there is no issue. Removing or using the ckcachecontrol variable does not change the outcome.

Screenshot from VSCode

Screenshot from Chrome Dev tools

Your configuration (any details about your system that you think might be relevant) OSX Catalina, Chrome Version 85.0.4183.102 (Official Build) (64-bit), Safari, FF

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

stenito commented 4 years ago

:) I see... :)

Steven

On 22 Sep 2020, at 17:30, Bryan Jones notifications@github.com wrote:

 What’s the external server address you’ve entered in CodeKit’s project settings?

-Bryan

On Sep 22, 2020, at 03:06, stenito notifications@github.com wrote:

 Quick, short summary: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used

Expected results: input type="reset" should stay "reset" đź‘Ť

Actual results: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used When surfing to the standard codekit preview URL the issue is there. When surfing to the external server URL directly on :5757 the issue is there. When surfing to the external server URL directly on its standard ports, there is no issue. Removing or using the ckcachecontrol variable does not change the outcome.

Screenshot from VSCode

Screenshot from Chrome Dev tools

Your configuration (any details about your system that you think might be relevant) OSX Catalina, Chrome Version 85.0.4183.102 (Official Build) (64-bit), Safari, FF

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

bdkjones commented 4 years ago

Yep. There’s your problem. Use a valid, fully-formed URI as it would appear on the Internet. I recommend reset.site or reset.test. (Reset.dev is an option, but requires TLS in Chrome.)

For speed, CodeKit does not parse the page to perform replacements. It simply swaps the proxy server address for all instances of the origin server address. Hence, all instances of “reset” are being replaced on your page.

-Bryan

On Sep 22, 2020, at 08:33, stenito notifications@github.com wrote:

 :) I see... :)

Steven

On 22 Sep 2020, at 17:30, Bryan Jones notifications@github.com wrote:

 What’s the external server address you’ve entered in CodeKit’s project settings?

-Bryan

On Sep 22, 2020, at 03:06, stenito notifications@github.com wrote:

 Quick, short summary: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used

Expected results: input type="reset" should stay "reset" đź‘Ť

Actual results: Chrome / Safari / FF preview replaces input attribute type value "reset" with window.location.host when an external server is used When surfing to the standard codekit preview URL the issue is there. When surfing to the external server URL directly on :5757 the issue is there. When surfing to the external server URL directly on its standard ports, there is no issue. Removing or using the ckcachecontrol variable does not change the outcome.

Screenshot from VSCode

Screenshot from Chrome Dev tools

Your configuration (any details about your system that you think might be relevant) OSX Catalina, Chrome Version 85.0.4183.102 (Official Build) (64-bit), Safari, FF

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.