bdkjones / CodeKit2

CodeKit 2 Beta
97 stars 4 forks source link

Less combined (inline) files are not mignified #544

Closed nicolastaffin closed 9 years ago

nicolastaffin commented 9 years ago

Hi, coming from : https://github.com/bdkjones/CodeKit/issues/463 (i wanted to combine & mignify several dev LESS files into one prod CSS file + map) it seems that the LESS output mignification options are not applied after successful import @import (inline) url("stylesheet.less"); Maybe i did it wrong. Thanks anyway for your GREAT work

bdkjones commented 9 years ago

Can you show me what the actual output is and what you expect the output to be?

nicolastaffin commented 9 years ago

stylesheet.less content : @import (inline) url("stylesheet2.less"); @import (inline) url("stylesheet3.less");

output: 2 files stylesheet.css stylesheet.map

stylesheet.css content :

selector {
    property: value;
    property: value;
}
anotherselector {
    property: value;
    property: value;
}

is not minified despite "Remove whitespace" is selected in the project settings and i expected:

selector{property:value;property:value;}anotherselector{property:value;property:value;}
bdkjones commented 9 years ago

Ah, yea. This is a problem in the 2.0 version of Less. Should be resolved with the next update, which will include the latest version of Less.

On 15 Apr 2015, at 14:37, Nico notifications@github.com wrote:

stylesheet.less content : @import https://github.com/import (inline) url("stylesheet2.less"); @import https://github.com/import (inline) url("stylesheet3.less");

output: 2 files stylesheet.css stylesheet.map

stylesheet.css content :

selector { property: value; property: value; } anotherselector { property: value; property: value; } is not minified despite "Remove whitespace" is selected in the project settings and i expected:

selector {property: value;property: value;}anotherselector {property: value;property: value;} — Reply to this email directly or view it on GitHub https://github.com/bdkjones/CodeKit/issues/544#issuecomment-93576310.

nicolastaffin commented 9 years ago

Ok thanks for your answer.

bdkjones commented 9 years ago

Should be fixed in 2.3

nicolastaffin commented 9 years ago

oops, sorry, you can reopen the issue cause it is not :-( I just checked when notified you were around.

nicolastaffin commented 9 years ago

Okay, the "compressed" option works and not the "remove whitespace" one.

bdkjones commented 9 years ago

You’re going to have to check with the Less.js team, because I think this is working as intended.

On 26 Apr 2015, at 21:54, Nico notifications@github.com wrote:

Okay, the "compressed" option works and not the "remove whitespace" one.

— Reply to this email directly or view it on GitHub https://github.com/bdkjones/CodeKit/issues/544#issuecomment-96503304.

nicolastaffin commented 9 years ago

With your latest version i now get this message. Useful ? "Compiled successfully, but with warnings: The compress option has been deprecated. We recommend you use a dedicated css minifier, for instance see less-plugin-clean-css."